Fix Build (#79) - Githubissues

alacarte-maps / alacarte

Renderer for OpenStreetMap tiles.

https://alacarte-maps.github.io/

Other

58 stars 18 forks source link

Fix Build (#79) #80

Closed Scheirle closed 7 years ago

Scheirle commented 7 years ago

Fixes #79.

florianjacob commented 7 years ago

Sorry for the inconvenience to have merged your PRs in the wrong order. :frowning:

florianjacob commented 7 years ago

Tried to solve rebase conflicts… EDIT: and failed. >.<

florianjacob commented 7 years ago

Big :+1: for the use of = default; instead of () { }, I actually didn't know / forgot that syntax existed.

The only thing I see left to do is to convert the remaining other constructors / destructors to that syntax to be consistently explicit (or delete them at your choice). A quick rg "\(\) \{\s*\}" turned up these candidates:

`~NonPrerenderingRequestManager() {}
MockSelector() {}
MockGeodata() : Geodata() {}
~PNGRenderCanvas() {}
~RenderCanvas() {}
RenderAttributes() {}

Scheirle commented 7 years ago

The only thing I see left to do is to convert the remaining other constructors / destructors to that syntax to be consistently explicit.

Done

florianjacob commented 7 years ago

Magnificent! :+1: for additional whitespace cleanup.

:shipit: