Closed Scheirle closed 7 years ago
Sorry for the inconvenience to have merged your PRs in the wrong order. :frowning:
Tried to solve rebase conflicts… EDIT: and failed. >.<
Big :+1: for the use of = default;
instead of () { }
, I actually didn't know / forgot that syntax existed.
The only thing I see left to do is to convert the remaining other constructors / destructors to that syntax to be consistently explicit (or delete them at your choice). A quick rg "\(\) \{\s*\}"
turned up these candidates:
MockSelector() {}
MockGeodata() : Geodata() {}
~PNGRenderCanvas() {}
~RenderCanvas() {}
RenderAttributes() {}
The only thing I see left to do is to convert the remaining other constructors / destructors to that syntax to be consistently explicit.
Done
Magnificent! :+1: for additional whitespace cleanup.
:shipit:
Fixes #79.