search

alacritty / vte

Parser for virtual terminal emulators
https://docs.rs/vte/
Apache License 2.0
242 stars 56 forks source link

Fix Tests #11

Closed nixpulvis closed 6 years ago

nixpulvis commented 6 years ago

Links against STD for tests to allow use of Vec.

nixpulvis commented 6 years ago

Hmmm, interesting. I didn't look at the .travis.yml... out of curiousity why is it only testing the utf8parse crate?

Also I can look into fixing the tests in that crate as well, I'm assuming it's going to be mostly the same thing.

jwilm commented 6 years ago

Thanks for working on this!

out of curiousity why is it only testing the utf8parse crate?

Most likely a series of oversights

jwilm commented 6 years ago

I think the reason only utf8parse is tested is that we didn't have any vte tests when travis was added. Should be easy enough to add to the .travis.yml, though.

nixpulvis commented 6 years ago

Everything passes now on travis... but I can't view the logs, it's giving me an error "There was an error while trying to fetch the log." so I'm not 100% sure that it's testing the vte crate itself now too.

jwilm commented 6 years ago

I'm able to see the logs now.

This all looks great; thanks for sending the PR!