Closed nixpulvis closed 6 years ago
Hmmm, interesting. I didn't look at the .travis.yml
... out of curiousity why is it only testing the utf8parse
crate?
Also I can look into fixing the tests in that crate as well, I'm assuming it's going to be mostly the same thing.
Thanks for working on this!
out of curiousity why is it only testing the utf8parse crate?
Most likely a series of oversights
I think the reason only utf8parse is tested is that we didn't have any vte tests when travis was added. Should be easy enough to add to the .travis.yml, though.
Everything passes now on travis... but I can't view the logs, it's giving me an error "There was an error while trying to fetch the log." so I'm not 100% sure that it's testing the vte crate itself now too.
I'm able to see the logs now.
This all looks great; thanks for sending the PR!
Links against STD for tests to allow use of
Vec
.