Closed julienfitz closed 8 years ago
This is exactly the right direction! Re: right place for the test; there's actually two crates here. There's the vte
crate and the utf8parse
crate. This test only involves the latter crate, so maybe it could all go under that tree?
No problem, can do! Thanks for the feedback, I will keep you posted on my progress.
I'm happy to give as much feedback as you like! Really, I'm just super jazzed that you decided to tackle this issue. Thanks :smile:
Started trying my hand at further implementation, but not really sure what I'm doing 😛
Feel free to take a look at the most recent commit - I left comments about what I didn't understand. I can elaborate on any details if needed!
Added a new commit with some failed efforts. Commented with the errors particular to the lines. I am a little tired so my brain is not working very well at the moment, but I figured I'd show you where I was at! Maybe it will make more sense to me in the morning 😛
I'll squash all these when I'm done, just FYI 😄
Thanks for the feedback! Sorry that I haven't been able to get back to this yet this week. Should be able to get back to it in a few days.
No worries! Take you time :)
Phew! Thanks for your patience. Okay, I think I'm a little further along, just having trouble figuring out exactly how to implement the utf8parse
version. Any hints you might be able to offer on the most recent commit?
Yeah! Take a peak at the "Parser::advance" method signature in the docs. Specifically, check how it wants the receiver to be passed. On mobile right now so can't get you a link easily, but I think there's one up this thread somewhere.
Sounds good! I'll let you know if I have any further questions. Thanks!
I guess there wasn't a link in this thread yet. Parser::advance()
I think I might have done it?? Let me know what you think! If it is in fact done, I can squash these commits.
Awesome! Let me grab your branch and give it a spin. Sadly I don't have travis set up yet because there was no tests up until now :flushed:
Okay, all done! Let me know if there's anything else I need to do. 😄
This is awesome! Thank you thank you thank you :grin: