Prevent overflow when parsing CSI/DCS parameters

alacritty / vte

Parser for virtual terminal emulators

https://docs.rs/vte/

Apache License 2.0

242 stars 56 forks source link

Closed Aaron1011 closed 7 years ago

Aaron1011 commented 7 years ago

To prevent a large CSI or DCS parameter from overflowing an i64, the value is limited to u16::MAX, for consistency with XTerm.

I found this bug with american fuzzy lop

Aaron1011 commented 7 years ago

@jwilm: If this looks good to you, I can squash the commits into one.

jwilm commented 7 years ago

Sounds good @Aaron1011. Thanks for the changes!

Aaron1011 commented 7 years ago

@jwilm: Anything else you need me to change?

jwilm commented 7 years ago

@Aaron1011 nope, looks great! Just needed a bump after the squash; my bad.

thanks again!