search

aladdin-add / eslint-plugin

autofix some errors reported by eslint rules.
106 stars 10 forks source link

no-autofix rules not working/not found with scoped packages #77

Closed keliel closed 2 years ago

keliel commented 3 years ago

Tell us about your environment

Seems like the rule in itself is working (not 100% sure), but linter from i.e. vscode is still reporting "Definition for rule 'no-autofix/@typescript-eslint/explicit-member-accessibility' was not found."

Since I didn't see the TODO written in the code and my use case is exactly that, I am just opening this issue to hopefully track the status. Would be nice, if this is resolved at some point 😄 https://github.com/aladdin-add/eslint-plugin/blob/dcb6993d6c377c5013051e4c894e90a49cda5e5b/packages/no-autofix/lib/rules.js#L51

abierbaum commented 2 years ago

Looks like this plugin would do everything I need if it just supported scoped plugins. I looked and I don't know enough about eslint to make this work.

aladdin-add commented 2 years ago

I'll look at this asap (maybe in a few days).

abierbaum commented 2 years ago

@aladdin-add Anything we can do to help? I looked at the code and it seems like it should be possible but I don't understand the logic so well to make sure I would do it right.

Axedyson commented 2 years ago

This should be reopened, I still have the same issue with: eslint-plugin-no-autofix: ^1.2.0

aladdin-add commented 2 years ago

this should be fixed in eslint-plugin-no-autofix v1.2.3.

confirmed in a repo: https://github.com/aladdin-add/eslint-plugin-no-autofix-issue77 ( it was not easy to write tests for this ╮(￣▽￣)╭, but will try later).