search

aladshaw3 / cats

Catalysis And Treatment Simulations (CATS) library for MOOSE
MIT License
5 stars 5 forks source link

Test failures on certain builds [Mac OS] (optimize and re-gold unit tests) #4

Closed aladshaw3 closed 2 years ago

aladshaw3 commented 2 years ago

Srikanth reported a test failure on a recent Mac build. Was fixed by changing solver options for the unit test. That said, should some of the unit tests be simplified / optimized? Seems like certain builds of MOOSE/PETSc on different OS may give slightly different results with slightly different efficiencies. Some of this is expected, but it shouldn't ever impact the unit tests.

Consider going over the suite of tests and finding how to make them more simple.

Should some unit tests only run for certain builds? Should some only run with parallelization?

aladshaw3 commented 2 years ago

Updated libmesh and regolded certain tests. This issue may still come up in the future unless I have some dedicated GitHub actions to run tests, but that would also require GitHub actions to automate building of the MOOSE framework. May be more trouble than worth.