search

alaegin / Detekt-Action

Run Detekt with reviewdog
MIT License
23 stars 24 forks source link

Build not failing on detekt error #25

Open hbmartin opened 3 years ago

hbmartin commented 3 years ago

Hi, thanks for this project. I have the following settings in my config: fail_on_error: true reviewdog_level: error

But even tho detekt is failing reviewdog still shows a pass: https://github.com/hbmartin/protobuf_java_to_protobufjs/runs/2255365060?check_suite_focus=true

Am I doing something wrong configuring this?

dawidhyzy-ifolor commented 2 years ago

I face the same issue, did you figure it out?

alsutton commented 3 months ago

This should be solvable using a new public release of reviewdog... soon... when they make it.

We've created our own fork, with a prerelease reviewdog, which at https://github.com/snappautomotive/Detekt-Action so folk can see what's involved. I'm not submitting a PR for this repo because it relies on a custom created version of reviewdog, and it'd be better to wait for the full release, but if you really need to use that functionality feel free to use our fork until the feature has been upstreamed.