alafr / SVG-to-PDFKit

Insert SVG into a PDF document created with PDFKit
MIT License
397 stars 111 forks source link

Make PDFKit a devDependency #160

Closed bendemboski closed 2 years ago

bendemboski commented 2 years ago

SVG-to-PDFKit doesn't actually depend on PDFKit at runtime, it expects its consumer to use PDFKit to instantiate a PDFKit PDFDocument and pass it in to SVG-to-PDFKit's API. So the consumer should already have its own dependency on PDFKit, and SVG-to-PDFKit having one just potentially results in an extra unused copy of it in node_modules.

I'm not sure that SVG-to-PDFKit even needs a devDependency on PDFKit, but perhaps it makes it easier to regenerate examples/pdfkit.js, so probably doesn't really hurt to keep.