Closed bboe closed 11 years ago
Thanks for merging. What are your thoughts on adding the following:
pre_message
callback that is emitted prior to any other message handling.post_message
callback that is emitted after all other message handling.I have monkey patched this in with a wrapper function to support this behavior in LazySusan. I get the impression you want to keep the API similar in each language so I figure this would be something to ask first about.
Also, I noticed that roomInfo
doesn't support passing a roomId. I know that you can only get room info for the rooms that are on the same chatsever, but even in the failure case the error message provides useful information. Can I add this as well?
Awesome ideas ! I really like the pre_message
and post_message
proposal :D
For the roomInfo
I didn't know that it was possible to get other rooms informations !
Go ahead !
The first commit removes the message id increment during the
_heartbeat
message as that does not occur on that message in the TT source.The second commit makes the package pep8 compliant. You can use the
pep8
tool to verify for yourself. Unfortunately due to switching from 3 spaces to 4 spaces it's very difficult to see the other changes that were made. Maybe try doing a diff between the previous version, and yours ignoring spaces.The third commit fixes the important errors that the
pylint
tool reports.