alaingilbert / Turntable-API

Allows you to create bots for turntable.fm
http://alaingilbert.github.com/Turntable-API/
MIT License
317 stars 97 forks source link

data.room undefined in busy rooms #132

Closed TheHolyWaffle closed 6 years ago

TheHolyWaffle commented 11 years ago

I'm having this error in the 'roomChanged' event. It only seems to happen when a room is really busy, like 210+ people.

MikeWills commented 11 years ago

Some API changes may need to be done when there is over 200 in the room. With how they implemented the changes for that.

bboe commented 11 years ago

To clarify, is it when the room becomes busy (your bot was in the first 200) or when your bot joins a room with already 200+ people? My understanding is that the "overflow" users have a slightly different view of the API including not being able to DJ or chat with the original 200 people.

MikeWills commented 11 years ago

Ya. I asked about this in issue #128

TheHolyWaffle commented 11 years ago

So far I've only experienced this when joining an already busy room. Also consistently retrying will eventually get you in after 6-10 tries.

Izzmo commented 11 years ago

If you are in the main room, then it stays the same as the section you are in is already 0.. but when you join a busy room, depending on how busy it is, you join at section 1+ if I am not mistaken, and that's when you need to start checking other things.

technobly commented 11 years ago

I like how nobody really knows how to handle something that TT could just simply tell us how it works. glares at TT Reverse engineering is fun when you don't have to continuously do it to maintain something you've created.

bboe commented 11 years ago

@DubbyTT officially supporting an API is a ton of work, especially when the backend is not open-source. Be happy they even allow bots at all.

MikeWills commented 11 years ago

I think they understand that we like the bots. http://blog.turntable.fm/post/35859648187/your-feedback-on-the-new-interface

Also, if you make extensions, bots, or other scripts, and you’d like to be on our informal mailing list please drop us a line at contact@turntable.fm with your name, a short description of your project, and any links to more info about what you’re working on. That way we can give you a heads up if we’re going to be making any changes that will affect your code and give you time to get it fixed.

I already signed up and made sure they talked to @alaingilbert

Izzmo commented 11 years ago

@bboe That is completely untrue. Having a decent outline for an API would do wonders or have a forum where we could ask questions. The backend doesn't have to be available at all and they have had ample time to release something with regards to documentation.. even if it was slow, any information would be acceptable at this point.

MikeWills commented 11 years ago

I would hope with the above quote they are starting to do that now.

Izzmo commented 11 years ago

@MikeWills I think they know that there is a big community of 3rd party "extensions," and they are just going to use it to warn people to fix them or notify them about upcoming updates a few days before they are released so they don't break peoples turntable.fm views.

technobly commented 11 years ago

I spend a SH*T TON of time on TT.fm, so I don't think it's unreasonable at all to expect more from them. Bots and extensions is the only reason I stay engaged at TT.fm... not to mention the reason why most people enjoy being in a room. My opinion of course.

Take away bots and extensions... ask yourself, are you going to stay?

Izzmo commented 11 years ago

Well I'll agree that's a major reason for people sticking around.. bare bones Turntable.fm will only keep you engaged for a short while.

MikeWills commented 11 years ago

I wouldn't be able to DJ in my room without @Izzmo Autoawesomer. I'd forget to awesome every song.

bboe commented 8 years ago

Can we close this issue since it no longer matters?

MikeWills commented 8 years ago

No. ;-)

Mike Wills http://mikewills.me Ph: 507-933-0880 On Feb 28, 2016 12:46 AM, "Bryce Boe" notifications@github.com wrote:

Can we close this issue since it no longer matters?

— Reply to this email directly or view it on GitHub https://github.com/alaingilbert/Turntable-API/issues/132#issuecomment-189801155 .