search

alaingilbert / Turntable-API

Allows you to create bots for turntable.fm
http://alaingilbert.github.com/Turntable-API/
MIT License
317 stars 97 forks source link

Updates #254

Closed ghost closed 11 years ago

ghost commented 11 years ago

Added:

  1. Song Info Bot Updated:
  2. Node Engine to v0.5.0

This Bot example helps new turntable.fm bot coders add Song Info to their turntable.fm bots. It also helps them expand on the bot example to make a advanced bot with awesome features like Vote Skipping, Queue Management, Auto-Djing, DJing Functions, and Battle Management.

MikeWills commented 11 years ago

Is this really needed?

alaingilbert commented 11 years ago

Why have you changed the "node engine" ?

Your code is not properly indented (it has been well explained here : https://github.com/alaingilbert/Turntable-API/pull/179)

Like @MikeWills said, is it really needed ?

ghost commented 11 years ago

I changed the node engine, because more people are using v0.5.0 these days and it is needed.

gizmotronic commented 11 years ago

Changing the engine version here means that we leave behind people still running v0.4.x, which at least one node.js hosting provider still supports. The old adage applies: if it ain't broke, don't fix it.

MikeWills commented 11 years ago

:+1:

Izzmo commented 11 years ago

Think of it like this.. ttapi works on 0.4.x .. so unless you actually need something from a later version, no need to update it. Always works for me in the industry and explanation is short and sweet when people ever ask.