Open ghost opened 5 years ago
This is how it should look like with the ratio of 7.5: the blue line should be 7.5 times longer that red line (beware ratio on figure is wrong)
I have checked the values computed for alphas,they are all correct.
Road generates and alpha of 1.437 rad (100 kph) while HST generate a alpha of 1.23 rad (250 kph)
So the error is after this step of computation:
this._edgesAndTranspModes = networkFromCities(transportModeCode, cities, transportNetwork);
The image below is beautiful, but unfortunately wrong :(
HST are red as in Beijing cone, the rest is road:
Very interesting, since the last update of @kaktus40, by canceling the angle of the correction while the azimuth difference is big and by setting coneStep to 1:
new problem, observed in newest verion including PR #78 and #80 : when resizing browser window, slopes change !! depth (am) remain the same while horizontal length change (ab)!!!
Ok I will fix it today!
a new idea of the issue, I made a video of China from unprojected to projected view: https://timespace.hypotheses.org/files/2019/10/cone_slope_bug.mp4 the problem is that the height of cones remain identical while radius changes in the transformation. As cones are gessting more distant, this generatesa new slope. What do you think of that @kaktus40 ?
another insight for solving the bug for @CodeInLight
shriveling.configuration.intrudedHeightRatio=0.9
the geometry is becoming crazy!summarizing exchanges by email and phone and Skype with @kaktus40 and @CodeInLight Diagnostic: geographical projections are designed to deal with the earth surface but are not designed to convert three-dimensional objects, which causes probably the issue Pathways to solve the bug:
if this proves costly in computing time, this solution could be only applied when a projection is at 100% applied and not during the transition between projections. Attention: this idea can bring additional complexity in the code, so trade-off must be devised
Here comes an explanation of the bug, inspired by repeating the transformation between un-projected and projected and back: All is said in the graphic, now let's find the solution to the issue!
Issues in the slope of cones:
Cones geometry (slope) varies significantly between unprojected and projected representation, which is not expected this is the unprojected view, look at Urumqi (left) slopes with the other cities of mainland China; the ratio is about 1 to 5 (which still is short of the theoretical 7.5) Now the same view with equirectangular projection; the ration is close to one to 3
measurement with the ruler shows inconsistency between visual ratio and theroretical speed ratio (see point 1)