search

alaisi / postgres-async-driver

Asynchronous PostgreSQL Java driver
Apache License 2.0
287 stars 38 forks source link

NettyPgConnectionPool does not wait for shutdownGracefully to complete #15

Closed Ryan-ZA closed 8 years ago

Ryan-ZA commented 8 years ago

https://github.com/alaisi/postgres-async-driver/blob/master/src/main/java/com/github/pgasync/impl/netty/NettyPgConnectionPool.java#L49

shutdownGracefully returns a future, which is discarded. The future should either be completed before returning, or there should be a close method that returns the future.

This causes problems in cases where the process ends before the shutdown completes, causing non-closed connections to remain open on postgres.

alaisi commented 8 years ago

Verified, thanks for the bug report.

alaisi commented 8 years ago

Fixed in release 0.7.