search

alakajam-team / alakajam

Website powering the Alakajam! game making community
https://alakajam.com/
Other
28 stars 13 forks source link

theme ranking strange behaviour #580

Closed bremco closed 3 years ago

bremco commented 3 years ago

I was on Win64/Chrome when this happened.

cards_on_top clockwork_on_top

The pictures probably paint a better picture, but here are the actions I took to get them: I wanted to drag the themes (Clockwork) around, but when I saved, the top eliminated theme (Cards) got placed on 1 instead, and swapped with the theme I had dragged. I could reverse it by dragging the previously eliminated theme around, then saving, and Clockwork was back on top (... I had it at 2, but I was doubting that anyway and don't really dare touch it again).

Whatever happens, I more or less like all the themes, but that might not be the case for everyone :-)

mkalam-alami commented 3 years ago

Thanks for the report, I'll try to reproduce asap

mkalam-alami commented 3 years ago

Oh yeah there's clearly something broken

mkalam-alami commented 3 years ago

Fixed with 5126c86, the patch is online

mkalam-alami commented 3 years ago

Ok it's still not perfect, I'll have to add an additional rule to avoid themes just barely eliminated to get back into contention

EDIT: quick fix would be to force the lower scores to be saved on eliminated themes, to prevent making an active theme reach a score below an eliminated one. For the next event we'll need to set up a proper persisted state for themes eliminated in the shortlist, instead of deciding it only at render time.