search

alallier / reload

node module to reload your browser when your code changes
MIT License
297 stars 47 forks source link

Update dependency serve-static to ~1.16.0 [SECURITY] #381

Open renovate[bot] opened 2 months ago

renovate[bot] commented 2 months ago

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
serve-static ~1.15.0 -> ~1.16.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-43800

Impact

passing untrusted user input - even after sanitizing it - to redirect() may execute untrusted code

Patches

this issue is patched in serve-static 1.16.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Release Notes

expressjs/serve-static (serve-static) ### [`v1.16.0`](https://redirect.github.com/expressjs/serve-static/blob/HEAD/HISTORY.md#1160--2024-09-10) [Compare Source](https://redirect.github.com/expressjs/serve-static/compare/v1.15.0...1.16.0) \=================== - Remove link renderization in html while redirecting

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR was generated by Mend Renovate. View the repository job log.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (13a1192) to head (966ea61).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #381 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 131 131 ========================================= Hits 131 131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gnuk commented 1 month ago

@alallier Maybe you may need to check this PR because this change may will resolves a security vulnerability (cf npm audit)