search

alamkanak / Android-Week-View

Android Week View is an android library to display calendars (week view or day view) within the app. It supports custom styling.
Apache License 2.0
3.42k stars 1.23k forks source link

onEmptyViewClicked not firing #240

Closed ToddManUtah closed 8 years ago

ToddManUtah commented 8 years ago

I've implemented this view in a fragment and it's AWESOME!!! Great job everyone.

I'm having a problem with the onEmptyViewClicked method. For some reason, it's not firing. My fragment implements WeekView.EmptyViewClickListener.

Other events like onEventClick are working great.

Any ideas?

entropitor commented 8 years ago

Does the longpress work?

ToddManUtah commented 8 years ago

Nope. I thought the 2 might be tied together. So I tried it and got the same problem.

Just to be clear. Long press on an event (onEventLongPress) works fine. It's long press (and short) on an empty space that's not working.

ToddManUtah commented 8 years ago

I just changed the sample project and got the same result. Empty click events (long and short) don't work.

entropitor commented 8 years ago

Hmm, does it work in earlier versions? Because if not really tried it yet. Maybe it got broken by accident in the latest version.

ToddManUtah commented 8 years ago

I just started using the library. I haven't tried earlier version. If you compile the sample project and add the callbacks you'll see the problem right away.

entropitor commented 8 years ago

This is indeed a problem. However I don't have the time to fix this right now. @marunjar can you maybe take a look?

marunjar commented 8 years ago

ok, i'll take a look, maybe tomorrow...

marunjar commented 8 years ago

i just added the onEmptyViewLongPress to the sample app for debugging (#245) but i works fine for me. Just tried it with 1.2.4 and develop branch on some avds and also on real devices. Zoomed in and out and also from day view to full week view.

@ToddManUtah Do i miss something? Do you have any additional infos or some code, e.g. of your changed sample project?

entropitor commented 8 years ago

(I'm gonna close this until @ToddManUtah confirms there is still a problem).

ToddManUtah commented 8 years ago

I'm still seeing the problem. I'm using a Nexus 9 running Marshmallow. The problem is easily reproduced using the sample project. I'm using the latest release of the code. Both short and long touch in empty space produces no event. Is there something you want me to try?

ExtinctAmoeba commented 8 years ago

Is there any fix for this issue?

entropitor commented 8 years ago

@ExtinctAmoeba Can you check if this problem is also present in the Quivr-fork?

And if so, can you add some steps to reproduce this error? Because I can't reproduce this error.

ExtinctAmoeba commented 8 years ago

@caske33 yes, Quivr fork works good. Thank You, I will look for code differences.

entropitor commented 8 years ago

@ExtinctAmoeba I suggest to just start using the Quivr-fork. I will be no longer doing any work on this repository and the only other official contributor to this repository is @alamkanak, who has been inactive for a long time now.