alamminsalo / orion

Cross platform Twitch.tv client
GNU General Public License v3.0
313 stars 60 forks source link

Better Chat? edit: change chat size on Windows 10* #138

Closed capitao3 closed 7 years ago

capitao3 commented 7 years ago

First, I wanna say this program is amazing. I've been looking for this for a very long time, it is stable and way better and easier to use than streamlink/livestreamer.

Thank you very much for it.

I only request better chat options and configuration, like allowing to make it bigger, BTTV or FFZ emotes, whispers etc.

This would be perfect. Again, thank you.

ahjolinna commented 7 years ago

@capitao3 : whisper feature was just implemented, what do u mean by bigger? (how much) also is the text size good enough? if not maybe there is a problem with the (hi)dpi feature, but if that is the problem maybe this new commit will fix it

capitao3 commented 7 years ago

Allow to drag and make chat bigger, with bigger letters and emotes, shrinking the stream, optionally. I use Orion like this: http://i.imgur.com/cYIJO8L.jpg cyijo8l

Instead of the normal way: http://i.imgur.com/2vQbG14.png 2vqbg14

It's actually because my sight sucks (even with glasses), it's not an issue of the program itself.

It would just help few people with pleb sight (me).

ahjolinna commented 7 years ago

as it seems you are on win10 and @rakslice is more the windows user/dev "here" I would "throw" this issue to him

capitao3 commented 7 years ago

Yes, I'm.

Thanks for replying, going to msg him.

rakslice commented 7 years ago

@capitao3 FYI, as a possible workaround, depending on the DPI that Qt detects for your monitor, setting the environment variable QT_AUTO_SCREEN_SCALE_FACTOR to 1 (System control panel [Win+Break] -> Advanced System Settings -> Advanced tab -> Environment Variables) may give you larger images and text for things that use pixel-sized fonts. See https://doc.qt.io/qt-5/highdpi.html#high-dpi-support-in-qt for more info on this.

Anyway, IMO there really should be a setting in Orion that adjusts font size, both for visibility issues and as a workaround when Qt gets a DPI value that doesn't correspond to reality. I'm thinking that a size dropdown on the settings screen with named presets would be best. This could just apply a factor to the dp() calculation, as widgets that contain text would need to be scaled along with the text. IMO if the chat area is made drag-resizeable people are going to resize it expecting it to show more chat, not larger chat.

rakslice commented 7 years ago

Another workaround is to just scale everything by setting QT_SCALE_FACTOR to whatever magnification factor makes sense for you.

ahjolinna commented 7 years ago

@rakslice : well maybe orion should have in settings to set some (pre-made) font sizes and/or force font DPI levels...kde/plasma5 has done it like this: image

amongst screen scaling setting: image

rakslice commented 7 years ago

I added separate issues for the emote feature requests https://github.com/alamminsalo/orion/issues/140 https://github.com/alamminsalo/orion/issues/141

ahjolinna commented 7 years ago

@rakslice : damn it seems those emote's are png based, why can't they be svg ...sigh...anyway... if there are any common sizes between those two (BetterTwitchTV and FrankerFaceZ emotes) why not make them as optional value in settings...just a dropdown menu that has a preview of those different sizes

capitao3 commented 7 years ago

@rakslice, I used QT_SCALE_FACTOR and the value 2, it's like this now: http://i.imgur.com/fCqPcpb.png

fcqpcpb

It worked, I'm impressed. The program is 100% fine for me now.

Thank you very much for the help @ahjolinna and @rakslice.