search

alamminsalo / orion

Cross platform Twitch.tv client
GNU General Public License v3.0
313 stars 60 forks source link

Reconnect loop when a channel goes offline/hosting #167

Open rakslice opened 7 years ago

rakslice commented 7 years ago

I noticed after leaving a stream opened unattended, and it went offline and switched to hosting another channel, that the Orion chat went into a reconnect loop. I'll attempt to reproduce this with non-streaming channel hosting when I have a chance, but if anyone else has better resources to reproduce this and debug that would help

ahjolinna commented 7 years ago

@rakslice : is there anyway to enable better debuging output on orion? as gdb doesnt give anything (I know there isnt any pkg-config, but something a like)

rakslice commented 7 years ago

Unable to reproduce this so far. Perhaps this could be reproduced with an actual stream that ends with a host.

I know that unnecessary disconnect/reconnects are triggered by network failures independent of the actual IRC TCP connection state; I wonder if those are related, and I should rework that in any case

rakslice commented 7 years ago

@ahjolinna You need a debug build to get debug output; pass an appropriate CONFIG= to qmake when building (see https://doc.qt.io/qt-5/qmake-variable-reference.html)

rakslice commented 7 years ago

(or for the time being, as release builds generate debug messages and then they get passed to a no-op message handler, for one-off purposes you can just comment out the line qInstallMessageHandler(noisyFailureMsgHandler); at ~ main.cpp:72 with // and rebuild)

ahjolinna commented 7 years ago

@rakslice : I got debuging working and I'm currently watching a stream that I know will end with host...90% sure

ahjolinna commented 7 years ago

@rakslice : okay done, here is the whole output: streamlog.txt

ahjolinna commented 7 years ago

@rakslice : unfortunately I didnt have that https://github.com/alamminsalo/orion/pull/172 "patch" and it seems to give way more output

ahjolinna commented 7 years ago

@rakslice : here is "log v2" using orion with that #172 "patch" streamlog-v2.txt

I'm currently using arch(testing) with Qt5.9 (and plasma5.10)