Esc no longer closes emote picker

alamminsalo / orion

Cross platform Twitch.tv client

GNU General Public License v3.0

314 stars 60 forks source link

Esc no longer closes emote picker #190

Open rakslice opened 7 years ago

rakslice commented 7 years ago

In the pre 1.6 versions, Esc closed the emote picker; this no longer works

rakslice commented 7 years ago

It seems that there are problems navigating between the emote picker search, the grid, and the chat text input box generally; I'll look into this further at some point.

ahjolinna commented 7 years ago

for me the esc only closes/hides the chat (the stable 1.6, on arch using Qt 5.9.1)...after multiple button tries/presses

alamminsalo commented 7 years ago

Found a bug regarding this, the ctrl + wheel prevented clicking links and interacting with chat. Whoopsydaisy. Fixed with removing the mousearea and adding small floating zoom buttons

rakslice commented 7 years ago

Okay, so a couple of things:

In Qt 5.9 / QtQuick 2.7, Esc key events do not happen by default but are available via shortcutOverride: https://doc.qt.io/qt-5/qml-qtquick-keys.html#shortcutOverride-signal
Focus switching by toggling the focus parameter does not work consistently anymore. I don't know of a solution to that yet.

rakslice commented 7 years ago

Okay, seems that using .forceActiveFocus() fixes the focus issue. Esc is still not getting picked up in the GridView for some reason despite providing shortcutOverride the same way as in the TextField.