search

alamminsalo / orion

Cross platform Twitch.tv client
GNU General Public License v3.0
315 stars 60 forks source link

no audio in 1.6.6(-git) #251

Closed ahjolinna closed 5 years ago

ahjolinna commented 5 years ago

for some reason I don't get any audio anymore with orion on openSUSE (tumblweed)....I use my own repo version not the "offical" one.

everything else works as it should, so it I don't think it's a problem with my system...I think

gdb doesn't give any errors

mrgreywater commented 5 years ago

Probs caused by this: https://github.com/alamminsalo/orion/commit/9fb2e6b3c15a6aab89798f8f91b7cbf53b12d853#diff-dae2dd70920f587d6de8c05d302f468eR100

I moved it from here https://github.com/alamminsalo/orion/commit/9fb2e6b3c15a6aab89798f8f91b7cbf53b12d853#diff-48e50e9fdd3b57abc0ec993a28b8ced4L590 where previously the log math was never applied, because Qt.platform === "linux" would never be true. (It's Qt.platform.os === "linux")

Removing the lines

if (Qt.platform.os === "linux")
    volume = Math.round(Math.log(vol) / Math.log(100))
else

should fix it.

ahjolinna commented 5 years ago

yeah that fixed it

mrgreywater commented 5 years ago

Should be fixed with #252

mrgreywater commented 5 years ago

can you close this issue if there are no more problems?