avoid just spinning forever when selected quality doesn't exist

alamminsalo / orion

Cross platform Twitch.tv client

GNU General Public License v3.0

313 stars 60 forks source link

avoid just spinning forever when selected quality doesn't exist #293

Closed rakslice closed 4 years ago

rakslice commented 4 years ago

Addresses the spinning forever when there is no stream for the selected quality mentioned in #292

if the selected stream or VOD doesn't have the quality from the settings (e.g. the last quality manually set with the dropdown), try "source" instead
if for whatever reason we still get a null URL, don't try playing the null UR, and log an error

QuLogic commented 4 years ago

Please, can you make a new release with this fix? It's reeaally annoying, because the quality dropdown doesn't even show up.

rakslice commented 4 years ago

Note that you if you want to try a commit on windows without waiting for a new release, you can just go to the Appveyor automated build job (https://ci.appveyor.com/project/alamminsalo/orion/branch/master -- you can find it from the Build Passing button in the Readme), pick x86 or x64, and go to the artifacts section and download the exe (which is the installer) from that build.

rakslice commented 4 years ago

But hopefully @alamminsalo can put up a new release soon?