search

alampros / react-confetti

Confetti without the cleanup.
http://alampros.github.io/react-confetti/
MIT License
1.51k stars 99 forks source link

Use passed in styles to override existing styles #115

Closed edjiang closed 3 years ago

edjiang commented 3 years ago

I'd love to use react-confetti but the z-index set won't work within our existing CSS framework.

This change allows styles in the props to override the default styles set in this package.

stale[bot] commented 3 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

edjiang commented 3 years ago

Not stale, needs review from @alampros

alampros commented 3 years ago

The styles are already being merged in from props on L55.

Am I missing something?

edjiang commented 3 years ago

Oops, my bad. Not sure why it didn't work before but I'll reopen if I see something.