@thoni56, there are a number of things that need to be fixed or added in Ch, 5, so I'm opening a PR and start proposing changes one commit at the time (so if we don't like something we can revert the commit).
I'm also annotating in comments the various problems that need to be addressed, so feel free to add their fixes by adding your commits to this branch.
Last time we used a PR to co-edit a chapter we ended up having trouble using the reviews system. Let's see if this time we can manage to handle discussing the various fixes without getting entangled with the reviews system.
Pending Tasks
[ ] In §5.1, first paragraph, clarify if Start At counts as a turn, i.e. if EVENTs and SCRIPTs are executed within Start, and what turn it will be after that (turn 0 or 1?).
[ ] We should clarify somewhere in this chapter what makes a turn click and what doesn't. E.g. META VERBs don't advance a turn, so EVENTs and SCRIPTs aren't executed. A misunderstood command doesn't count, right? What about failed CHECKs? or attempting to use a VERB that violates the WHERE clause of the syntax? Authors needs this info to understand how turns interact with EVENTs and SCRIPTs. There's already a phrase stating:
If the player enters an empty command, this is equivalent to forfeiting the turn.
@thoni56, there are a number of things that need to be fixed or added in Ch, 5, so I'm opening a PR and start proposing changes one commit at the time (so if we don't like something we can revert the commit).
I'm also annotating in comments the various problems that need to be addressed, so feel free to add their fixes by adding your commits to this branch.
Last time we used a PR to co-edit a chapter we ended up having trouble using the reviews system. Let's see if this time we can manage to handle discussing the various fixes without getting entangled with the reviews system.
Pending Tasks
[ ] In §5.1, first paragraph, clarify if
Start At
counts as a turn, i.e. if EVENTs and SCRIPTs are executed withinStart
, and what turn it will be after that (turn 0 or 1?).[ ] We should clarify somewhere in this chapter what makes a turn click and what doesn't. E.g. META VERBs don't advance a turn, so EVENTs and SCRIPTs aren't executed. A misunderstood command doesn't count, right? What about failed CHECKs? or attempting to use a VERB that violates the WHERE clause of the syntax? Authors needs this info to understand how turns interact with EVENTs and SCRIPTs. There's already a phrase stating:
so maybe this info should go there.
[ ] Clarify THEM player-word (see #127).