search

alan-if / alan-i18n

ALAN Internationalization Project
Other
0 stars 1 forks source link

Update Wearables Test, fix GNA issues #41

Closed Rich15 closed 2 years ago

Rich15 commented 2 years ago

Plural NPC's

Add two plural NPC's (gemelos and gemelas) to check GNA messages.

Femenine actors

Modify persona.i module so it handles femenine actors correctly. Add Is femenina to hembra class, so female actors are now mentioned with a femenine article:

Every hembra IsA persona
  Is femenina.
  Pronoun her.
End every hembra.

'tomar' verb

Modify tomar.i messages to correctly handle GNA when an object is already taken.

Previously all objects were mentioned in masculine singular, i.e. "ya lo tienes" and "lo llevas puesto". Modify messages to handle all four GNA cases (m.s., m.p., f.s. and f.p.).

tajmone commented 2 years ago

@Rich15, thanks for the fixes!

Two files didn't pass the Travis CI check

So I've fixed them and amended your commit, then force pushed (ensure you REBASE).

The error was due to the presence of trailing spaces in both files, so I think there's a problem with your editor's support for EditorConfig, since it's not cleaning up trailing spaces at save time. If it's a bug in the editor, just ensure you manually run some native function to remove trailing space.