Add support for extra_deps, needed for llvm_ocaml.h

jberdine commented 3 years ago

In LLVM main, there is now a llvm/bindings/ocaml/llvm/llvm_ocaml.h file. The creation of static and shared directories performed by setup.sh breaks #include "llvm_ocaml.h". This patch works around this by adding support for adding extra_deps to the generated dune files for llvm_ocaml.h, and adds some -I flags to find it.

I make no claims that this is a good solution.

jberdine commented 3 years ago

Also, the new header file will be included, I think, only starting with LLVM 13.

kit-ty-kate commented 2 years ago

Sorry for all the time it took me to come back to llvm..

I used a different solution by simply always copying llvm_ocaml.h so that we don't have any maintenance cost in the future.

See: https://github.com/kit-ty-kate/llvm-dune/commit/7512ef851a08ff276e1353e661097d6e9f20ca89

However upon testing:

LLVM 11 works fine
LLVM 12 works fine
but LLVM 13 makes my tests crash with:
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.
209655 Segmentation fault (core dumped) labrys build-program Basic.sfw

[139]


This also happens with the regular `llvm.13.0.0` and `llvm.14.0.0` package. I'm going to investigate.

alan-j-hu / llvm-dune

Add support for extra_deps, needed for llvm_ocaml.h #4