search

alan-j-hu / llvm-dune

The official LLVM OCaml binding but built using dune
Other
25 stars 3 forks source link

Point submodule to patches #7

Closed alan-j-hu closed 1 year ago

alan-j-hu commented 1 year ago

I apologize for not working on LLVM as much recently. I was busy with other tasks. I think this is the best solution.

I am very reluctant to try to upstream anything with Dune to LLVM, because I think Dune doesn't play along well with multi-language or non-standard projects and I think the other LLVM developers will be annoyed by OCaml-specific tooling. So, it's best to keep a separate repo that points to the LLVM repo (or a fork, as this PR does) with a script that generates the Dune files for opam packaging.

kit-ty-kate commented 1 year ago

this PR only updates the gitmodule file, not the submodule itself. Could you update the attached commit for the submodule too?

alan-j-hu commented 1 year ago

Thank you for the catch. I also realized that the branch name was wrong.

There is also https://github.com/ocaml/opam-repository/pull/24093. You can decide whether you want to use Dune or keep using the old build system. (However, I do not expect the LLVM upstream to use Dune.)

kit-ty-kate commented 1 year ago

ok YOLO. Thanks a lot! I'll release that and let's see what people actually prefer between https://github.com/ocaml/opam-repository/pull/24093 and this release.

Sorry for the delay, my body decided that enough was enough three months ago and I'm still recovering