search

alan-mj-lin / Sporeas

TJC projection webapp for service use.
1 stars 0 forks source link

#70 refactor sidebar stuff and add right sidebar stub #72

Closed hchiam closed 4 years ago

hchiam commented 4 years ago

@alan-mj-lin feel free to take over this branch and replace this comment with what you want: 

<!-- put stuff here -->

If you're curious, there's 2 simple things I did to make it work: 1) Set thez-index ("z coordinate") of .sidebar.right to be higher than the z-index of the main content. 2) Make the padding-righta little bigger on the right side of the .pusher (which holds the main content).

Screen Shot 2020-02-20 at 20 38 14
alan-mj-lin commented 4 years ago

@hchiam I'm not going to merge this in yet, but leave this branch available to me to mess around with it - and then once the its ready I'll merge it in

alan-mj-lin commented 4 years ago

@hchiam I am committing to this branch if that's ok

hchiam commented 4 years ago

@alan-mj-lin go ahead, I'm going to leave this branch alone unless you ask me to pitch in.

hchiam commented 4 years ago

@alan-mj-lin I fixed a merge conflict in this PR, so the branch "sidebars-on-both-sides" just got updated

hchiam commented 4 years ago

@alan-mj-lin so i guess we can close this too? https://github.com/alan-mj-lin/Sporeas/issues/70#issuecomment-601848374

alan-mj-lin commented 4 years ago

@hchiam yeah I suppose. I don't really see a need for this anymore.