Closed hchiam closed 4 years ago
@hchiam I'm not going to merge this in yet, but leave this branch available to me to mess around with it - and then once the its ready I'll merge it in
@hchiam I am committing to this branch if that's ok
@alan-mj-lin go ahead, I'm going to leave this branch alone unless you ask me to pitch in.
@alan-mj-lin I fixed a merge conflict in this PR, so the branch "sidebars-on-both-sides" just got updated
@alan-mj-lin so i guess we can close this too? https://github.com/alan-mj-lin/Sporeas/issues/70#issuecomment-601848374
@hchiam yeah I suppose. I don't really see a need for this anymore.
@alan-mj-lin feel free to take over this branch and replace this comment with what you want:
If you're curious, there's 2 simple things I did to make it work: 1) Set the
z-index
("z coordinate") of.sidebar.right
to be higher than thez-index
of the main content. 2) Make thepadding-right
a little bigger on the right side of the.pusher
(which holds the main content).