search

alan-mj-lin / Sporeas

TJC projection webapp for service use.
1 stars 0 forks source link

Spaces in Connected Room Breaks Projection Functionality #94

Closed eaneatfruit closed 4 years ago

eaneatfruit commented 4 years ago

Description

The Sporeas application currently does not support churches located in a city with a space in its name. For example - New York, East Bay, and among others. It is not possible for the application to perform its main function if the user opts to enter into a room with a space in its input.

Evidence

As proof of concept, the below screenshot demonstrates an already connected room. Suppose "East Bay" TJC was using the application for AV purposes. The below screenshot shows two red rectangles. When submitting, the WSS networking tab shows empty responses implying that socketio connections are not being made. The right red rectangle implies that the space in the URL might be the culprit breaking the functionality.

image

Remediation

Spaces in URLs should be encoded to the %20 character.

hchiam commented 4 years ago

Will need to test to make sure the %20 encoding doesn't break some variables.