alan-sdk / alan.dart

Pure Dart library allowing you to easily integrate with any Cosmos-based chain.
MIT License
32 stars 31 forks source link

feat(platforms): enable web platform support #194

Closed levischechter closed 1 year ago

levischechter commented 1 year ago

Description

Use GrpcOrGrpcWebClientChannel class from grpc package so also browsers will be able to communicate with the GrpcWeb server of cosmos-sdk based blockchains.

Closes #172

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 17.64% and project coverage change: -0.69 :warning:

Comparison is base (292e83a) 76.70% compared to head (454f0e5) 76.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #194 +/- ## ========================================== - Coverage 76.70% 76.02% -0.69% ========================================== Files 26 26 Lines 674 684 +10 ========================================== + Hits 517 520 +3 - Misses 157 164 +7 ``` | [Impacted Files](https://app.codecov.io/gh/alan-sdk/alan.dart/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alan-sdk) | Coverage Δ | | |---|---|---| | [lib/transactions/sender/tx\_sender.dart](https://app.codecov.io/gh/alan-sdk/alan.dart/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alan-sdk#diff-bGliL3RyYW5zYWN0aW9ucy9zZW5kZXIvdHhfc2VuZGVyLmRhcnQ=) | `69.23% <0.00%> (ø)` | | | [lib/transactions/signer/tx\_signer.dart](https://app.codecov.io/gh/alan-sdk/alan.dart/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alan-sdk#diff-bGliL3RyYW5zYWN0aW9ucy9zaWduZXIvdHhfc2lnbmVyLmRhcnQ=) | `75.55% <ø> (ø)` | | | [lib/wallet/network\_info.dart](https://app.codecov.io/gh/alan-sdk/alan.dart/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alan-sdk#diff-bGliL3dhbGxldC9uZXR3b3JrX2luZm8uZGFydA==) | `52.11% <18.75%> (-3.63%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

RiccardoM commented 1 year ago

Thanks for your contribution @levischechter! May I ask what's the difference between this and #172? I was actually waiting someone to test that before merging it

levischechter commented 1 year ago

@RiccardoM In the previous one I didn't used the right ClientChannel as the abstract class, and I didn't enabled the option to use separate hosts for the grpc and the grpcweb protocols

RiccardoM commented 1 year ago

Thank you so much for your contribution! :pray: