alan-turing-institute / AssurancePlatform

Project to facilitate creation of Assurance Cases
MIT License
22 stars 6 forks source link

[User Story]: Display Parent Element Description in Child Element Interface #457

Open kallewesterling opened 4 months ago

kallewesterling commented 4 months ago

Role

As an assurance case editor

Desired Feature

I want to view the description of a parent element when I am adding or editing a child element

Benefit

So that I can easily reference the parent's details to ensure that my contributions are consistent and appropriately aligned with the parent's claims and objectives

Acceptance Criteria

GIVEN I am editing an assurance case, AND I am about to add or edit a child element (Strategy, Context, Property Claim, or Evidence), WHEN I initiate the process to add or edit the child element, THEN I should automatically see the description of the corresponding parent element displayed in a clearly visible area of the interface.

GIVEN the parent element's description is displayed, WHEN I read the description while adding or editing a child element, THEN the description should remain visible and legible to assist me in formulating the child element's details.

GIVEN I am using the feature to add or edit child elements, WHEN I navigate through different parent elements, THEN the displayed description should update dynamically to match the currently selected parent element.

Dependencies

Technical Notes

It could be added above "Create new claim" in the screenshot below:

Screenshot 2024-05-30 at 16 34 52

Definition of Done

RichGriff commented 3 months ago

So now in each elements edit sheet we can see their parents description. I have also added in a eye icon for toggling the description just in case the user doesn't want to see it.

Image

RichGriff commented 3 months ago

In staging - @chrisdburr please review.

chrisdburr commented 3 months ago

Thanks, @RichGriff. I like the eye icon.

One small request: could we show the parent's identifier as well (e.g. S1, P2)?

I like how this is formatted in the search query (e.g. as a smaller gray font).

And, a question:

Do you think there is a better layout for the sidebar that we could switch to? For instance, I'm wondering if the parent's description should be below the description of the target element. I'm wondering about information hierarchy. So, what's the most salient information for our users to see.

RichGriff commented 3 months ago

In staging - please review

chrisdburr commented 3 months ago

I'm still unsure about the way this information is presented.

I think it needs to be separated visually from the rest of the information, perhaps using something like a callout:

[!NOTE] Description of the parent element. Parent Identifier.

I like how the Material for MKDocs SSG does them: https://squidfunk.github.io/mkdocs-material/reference/admonitions/#supported-types

If using collapsible blocks, we could switch to a simple arrow/chevron icon and keep the default state as hidden.

chrisdburr commented 3 months ago

I can't change the way GitHub renders callouts, but if you think this is a good way to go, @RichGriff I would suggest the following:

ℹ️ Parent Element Description {Description of the parent element.} {Parent element identifier}

chrisdburr commented 2 months ago

Will come back to this after @RichGriff has had a play around with alternate UI options.

chrisdburr commented 1 month ago

@RichGriff, any more thoughts on alternate UI options?