[Bug]: Revise the modal that shows when user clicks outside of edit panel

[kallewesterling]

Revise the modal that shows when user clicks outside of edit panel:

• reverse the buttons
• "Continue" should be "Discard changes"

[RichGriff]

@kallewesterling I can easily change the text no problem. However, reversing the buttons doesnt look as good.

Current position

New position

Also the position will effect other places we use this modal - i.e when deleting a node or case

[RichGriff]

This is now in staging awaiting feedback from @kallewesterling and @chrisdburr

[chrisdburr]

Hmmm. I'm a little torn now.

I've done a quick search on Google to see what the common design pattern is for this, and you are right @RichGriff that the current position is the default in terms of ordering and colouring.

The only other thing I've come across is to use less ambiguous language, such as with the following example:

So, perhaps it's best to keep the original ordering, but revise the text a little to help clarify the actions.

[RichGriff]

@chrisdburr @kallewesterling so the button has changed to Discard Changes - is this ok to close or do you want to change this?

[chrisdburr]

Please update the text for this editing modal to the following:

Are you sure? You have changes that have not been updated, would you like to discard these changes?

• Yes, discard changes!
• No, keep editing.

And, please also add a modal for when there are unsaved changes for new elements, as there is currently no pop-up (see video).

https://github.com/alan-turing-institute/AssurancePlatform/assets/63010234/9a4b8f9a-599d-4375-8a8a-a511b444c14f

And, for consistency, please update this other modal when deleting an element (and its children). There used to be a warning about deleting all elements, but it appears to have been removed:

Are you sure? Deleting this element will also remove all of the connected child elements. This cannot be undone.

• Yes, delete this element!
• No, keep the element.

We will need to update the text for the latter when we have addressed issue #475.

[RichGriff]

I have updated the Alert that pops up when editing but also the one when deleting an element - as they were in the same place. @chrisdburr just need a bug/issue raised for the alert when creating an element.

[RichGriff]

PR https://github.com/alan-turing-institute/AssurancePlatform/pull/512

[RichGriff]

Now in staging to be reviewed

[RichGriff]

@chrisdburr can you review this when you have some time, thanks.

[chrisdburr]

Thanks, @RichGriff.

I overlooked my bad grammar in one of the modals. Sorry. Please could you update the editing warning text to the following:

You have changes that have not been updated. Would you like to discard these changes?

[RichGriff]

In staging - @chrisdburr please review

[chrisdburr]

Thanks. All good.