alan-turing-institute / AssurancePlatform

Project to facilitate creation of Assurance Cases
MIT License
17 stars 6 forks source link

[Backend] Updating identifiers when the diagram is modified #479

Closed cptanalatriste closed 2 weeks ago

cptanalatriste commented 3 weeks ago

The following events trigger a re-calculation of the item identifiers:

The new identifiers are written on the database. If the frontend re-renders the diagram, the ids should be reflected.

DO NOT MERGE UNLESS EXTENSIVE TESTING IS PERFORMED!

This is an emergency PR for unblocking @RichGriff for next workshop features: I've manually verified the changes work using the legacy front-end, but further testing is required, specially with the new frontend and corner-cases.

Automated tests are still pending. I will deliver them once the HackWeek is over.

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 9455924708

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/views.py 13 28 46.43%
<!-- Total: 16 31 51.61% -->
Files with Coverage Reduction New Missed Lines %
eap_backend/eap_backend/settings.py 4 90.91%
eap_backend/eap_api/views.py 59 58.82%
<!-- Total: 63 -->
Totals Coverage Status
Change from base Build 9380433823: 0.1%
Covered Lines: 1279
Relevant Lines: 1573

💛 - Coveralls
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 9455928470

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/views.py 20 33 60.61%
<!-- Total: 20 33 60.61% -->
Totals Coverage Status
Change from base Build 9380433823: 0.1%
Covered Lines: 1279
Relevant Lines: 1573

💛 - Coveralls
RichGriff commented 3 weeks ago

@cptanalatriste We shouldn't be merging this into main - it should be into develop but not until the frontend dev has been completed.

I will take a look at your branch, did you create that branch from develop ?

cptanalatriste commented 3 weeks ago

@cptanalatriste We shouldn't be merging this into main - it should be into develop but not until the frontend dev has been completed.

I will take a look at your branch, did you create that branch from develop ?

I branched from main

RichGriff commented 3 weeks ago

@cptanalatriste ah right okay. Will try and take your branch and merge it into the develop or another working branch to test the changes.

We'll have to cancel this pull request as we shouldn't be pushing into main unless its a release.

kallewesterling commented 3 weeks ago

Would it be possible for us to do a git rebase based on the ttw-conversion branch? It may be an easier way than trying to go via the main branch, which doesn't have any of the updates on the frontend from Rich?

cptanalatriste commented 2 weeks ago

These functional was already moved into develop as part of another PR.