Open chrisdburr opened 2 weeks ago
@chrisdburr this is the expected behaviour as we reload the chart after adding a new element. Which pulls the new updated assurance case and re-creates the nodes for that case, updating the assurance case in the state. Therefore, removing any elements that had been toggled to hide.
@RichGriff, I appreciate it may be the expected behaviour, but it's not desirable as a user.
Here's another example of how this is frustrating. In this example, I add a new element to the right-hand side of the case and when the case reloads I am moved to the left-hand side of the case.
Constantly moving around to get back to where you were is not good UX. If this needs to be revised into a broader issue, and not a bug, that's fine. But we need to change this behaviour to improve the user experience.
@chrisdburr The only thing we can do here then is not reload the screen which is what we had before we put in place the identifier stuff.
Would need to store the hidden value for each node.
Myself and @cptanalatriste - have checked the feasibility of this and have identified about 1 week of work. @chrisdburr to discuss next sprint planing.
Thanks, both. It was flagged as an annoyance by multiple users in our workshops, so I think it's probably worth the effort. Let's discuss next week.
Notes: @RichGriff to look at the following:
Progress update
The last part here is going to be difficult as we currently re-render the nodes when the assurance case in state changes
Big improvement with just these first fixes, @RichGriff.
I don't understand the final issue with the hidden value, but appreciate the status update.
So this one has been a little pain but i think i have nailed the last point - retaining to the hidden state.
The below video should show the following:
Evidence element bug
Incorrectly setting hidden value on evidence. Correction was to look at at parent hidden if there are no siblings.
This is now in staging
@chrisdburr can you please review.
Issue
If a user has collapsed a branch, and then goes on to add a new element to a separate branch, when the case refreshes all branches are expanded.
Note in this video how
S3
is collapsed, and then a new element is added to a child ofS4
. When the case is refreshed,S3
is expanded.https://github.com/alan-turing-institute/AssurancePlatform/assets/63010234/f244f82b-ea8d-432c-804a-b5bf1b3c5129
Desired Behaviour
Expanded/collapsed states should persist.