alan-turing-institute / AssurancePlatform

Project to facilitate creation of Assurance Cases
MIT License
17 stars 6 forks source link

Reorder 'add {element}' buttons in sidebar. #493

Closed chrisdburr closed 1 week ago

chrisdburr commented 2 weeks ago

Please ensure that the sidebar buttons always follow this ordering (from top to bottom), regardless of which element is currently selected:

Add context Add strategy Add property claim Add evidence

As the following screenshot shows, when adding a new element to a property claim, the first option presented is 'evidence'.

Screenshot 2024-06-19 at 11 25 47
chrisdburr commented 2 weeks ago

Please also ensure the naming convention is as follows:

RichGriff commented 2 weeks ago

Fixed: Link buttons now follow the requested order.

Screenshot 2024-06-20 at 10 11 04

https://github.com/alan-turing-institute/AssurancePlatform/commit/64c9a33bb53bbaba75a7f1a429cbd788a7939f84

chrisdburr commented 2 weeks ago

Thanks, @RichGriff. Please can you confirm this is the case for all elements, and not just the 'Goal' element (as depicted).

RichGriff commented 2 weeks ago

@chrisdburr yes I have added this for all elements and only showing the ones that they can link to as before

chrisdburr commented 2 weeks ago

Great. Thanks, @RichGriff.

RichGriff commented 2 weeks ago

Verified with Rich and Carlos on a development call

cptanalatriste commented 2 weeks ago

Please verify in staging

chrisdburr commented 2 weeks ago

I can confirm this is correct. Please link to relevant PR when closing issue.

cptanalatriste commented 1 week ago

Addressed during PR: https://github.com/alan-turing-institute/AssurancePlatform/pull/501 . Closing as agreed with @chrisdburr