search

alan-turing-institute / AssurancePlatform

Project to facilitate creation of Assurance Cases
MIT License
17 stars 6 forks source link

[BUG] Add evidence URL as option when creating evidence #500

Open chrisdburr opened 2 weeks ago

chrisdburr commented 2 weeks ago

As highlighted in #442 when a user adds an evidence element, there is no option to add a URL. It requires reselecting the evidence element after creation.

Please can we add this field during element creation?

RichGriff commented 4 days ago

Evidence url now available on the evidence create form

Image

RichGriff commented 4 days ago

In staging - @chrisdburr can you please review, thanks.

chrisdburr commented 2 days ago

Thanks, Rich. Seems good 👍

Happy to close, but would suggest we look into additional form input validation when we know more about the types of inputs we wish to allow.

chrisdburr commented 2 days ago

Sorry, reopening as I have just found a bug while reviewing another issue.

If the user leaves the URL field blank and then clicks the 'add' button, nothing happens and the button is left selected. You can't then add a URL subsequently.

https://github.com/alan-turing-institute/AssurancePlatform/assets/63010234/0f03dc3e-3a49-4c9c-a74b-cdac86b8c0dd

I suggest we allow the users to leave the URL blank rather than enforcing this. However, we should make sure that a NULL value is added to the DB.

RichGriff commented 1 day ago

Corrected the api to allow for Null value for the URL when creating Evidence.

RichGriff commented 1 day ago

In PR waiting on review