alan-turing-institute / AssurancePlatform

Project to facilitate creation of Assurance Cases
MIT License
18 stars 6 forks source link

500 bug evidence url #527

Closed RichGriff closed 3 weeks ago

RichGriff commented 3 weeks ago

Corrected the api to allow for Null value for the URL when creating Evidence.

@cptanalatriste can you please review this change - i didn't need to change anything on the frontend. When debugging I found that I was getting a 400 Bad Request from the api as this was marked as required.

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 9797297026

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/models.py 4 8 50.0%
eap_backend/eap_api/view_utils.py 47 52 90.38%
eap_backend/eap_api/views.py 27 49 55.1%
<!-- Total: 223 254 87.8% -->
Files with Coverage Reduction New Missed Lines %
eap_backend/eap_api/views.py 2 66.03%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 9595513730: 3.3%
Covered Lines: 1487
Relevant Lines: 1761

💛 - Coveralls
RichGriff commented 3 weeks ago

Sorry cancelling this as i accidentally linked to main