search

alan-turing-institute / CROP

CROP is a Research Observation Platform
MIT License
25 stars 5 forks source link

Ges model forecast weather data #363

Closed dsj976 closed 2 years ago

dsj976 commented 2 years ago

A new attempt to incorporate weather forecasts into the GES model. The previous attempt did not work because historical weather data was first being written to .csv files after retrieving it from the database, after which the data was read from the .csv file by the GES model - something I hadn't realized. This is because the USE_LIVE flag in TestScenarioV1_1.py is set to False, i.e. the GES model reads data from disk rather than pulling it from the DB when it needs it. A similar approach has been followed for forecast weather data. The code has been run locally and works fine. A comparison between temperature predictions without (top) and with (bottom) weather forecasts is shown below.

image

mhauru commented 2 years ago

I added one commit that just runs black. Looks good, fine to merge by me. I left one comment that's entirely optional to attend to.