search

alan-turing-institute / CROP

CROP is a Research Observation Platform
MIT License
25 stars 5 forks source link

Unify data access for ARIMA and GES models #430

Closed mastoffel closed 1 year ago

mastoffel commented 1 year ago

The PR does two things:

1) Merge two separate data-access modules into one model_data_access.py which now lives in cropcore. 2) Makes the data access for ARIMA flexible: Tables, columns and joins can now be specified in the existing config.ini, which is now configured to obtain the same two data tables / columns which were previously hardcoded.

dsj976 commented 1 year ago

Will close this and open another pull request in order to run the latest GitHub Action tests.

dsj976 commented 1 year ago

Undoing this - this was unnecessary

dsj976 commented 1 year ago

thanks Martin, this looks very good, great work!

mastoffel commented 1 year ago

Thanks David! Glad it worked!