search

alan-turing-institute / CleverCSV

CleverCSV is a Python package for handling messy CSV files. It provides a drop-in replacement for the builtin CSV module with improved dialect detection, and comes with a handy command line application for working with CSV files.
https://clevercsv.readthedocs.io
MIT License
1.24k stars 70 forks source link

standardize : allow users to specify output encoding #118

Closed jbdesbas closed 7 months ago

jbdesbas commented 9 months ago

Add -E --target-encoding argument, so the user can specify an output encoding. If omitted, keep the original encoding.

jbdesbas commented 8 months ago

hi @GjjvdBurg , thank you for you review . I agree with your comments :+1: and I'll work on it as soon as possible

GjjvdBurg commented 7 months ago

Change looks good to me! There's some formatting errors that hopefully should be easy to fix by running black on your code.

GjjvdBurg commented 7 months ago

The code looks good to me but unfortunately the tests are failing on windows. Let me know if you'd like any help investigating

jbdesbas commented 7 months ago

You're right, it makes sense since Windows use non-utf8 as default encoding. a6f548e should solve. Don't have Windows environment at hand, but I hope it will be OK. Fortunaly, the tests alone seem to be affected.

GjjvdBurg commented 7 months ago

All tests passed! :tada: Thanks again for contributing @jbdesbas!