alan-turing-institute / CleverCSV

CleverCSV is a Python package for handling messy CSV files. It provides a drop-in replacement for the builtin CSV module with improved dialect detection, and comes with a handy command line application for working with CSV files.
https://clevercsv.readthedocs.io
MIT License
1.25k stars 72 forks source link

Migrate cchardet to faust-cchardet #83

Closed GjjvdBurg closed 1 year ago

GjjvdBurg commented 1 year ago

This PR moves the optional dependency cchardet to the fork faust-cchardet. Moving to chardet-normalizer was attempted, but this didn't pass the test cases without significant modification.

dotlambda commented 1 year ago

Why do you require both on Python < 3.11?

GjjvdBurg commented 1 year ago

@dotlambda That was a temporary configuration as wheels weren't available for faust-cchardet when v0.7.5 came out. CleverCSV v0.7.6 only needs faust-cchardet.