Closed GiorgioCerro closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6192b69
) 86.86% compared to head (a2c9371
) 86.86%.:exclamation: Current head a2c9371 differs from pull request most recent head e0e142d. Consider uploading reports for the commit e0e142d to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks a lot Markus. I applied all the changes you suggested.
Hi Giorgio, Great changes! Could you try adding a test too? Something simple like checking the html is on the page? Think you should be able to take inspiration from the other frontend tests. :)
Thanks Edwin. I added a test that looks for the eye icon in the user page (test_frontend_user) and I created a new script test_frontend_login to do some tests on the login page. At the moment the only test (test_elements) looks for the right elements in the page, i.e. username box, pass box, eye icon and login button. The test for the actual login attempt is already in the conftests script, so I haven't duplicated it.
I think now this PR should be ready to be merged and solve #151 and #140
I added the little eye to show/hide the password both in the login page and in the create_user form. In the user form, when we add users, the eye gets shifted because I didn't specify where to place it yet. I will create another issue to restyle the user form.
Please, check if the button works and you can see and hide the password.