alan-turing-institute / DTBase

A starting point from which digital twins can be developed.
MIT License
11 stars 4 forks source link

Update pulumi config #152

Closed mhauru closed 11 months ago

mhauru commented 11 months ago

There are a few things going on here

In some sense this is a regression, since the Pulumi deployment used to just work, and now one part of it fails, and you have create the database manually. However, given that we do some serious upgrading to newer versions for pulumi, postgres, and Azure postgres servers here, I think it might still be worth to merge this.

Closes #148 and #138

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ddb9111) 86.86% compared to head (2d5898f) 86.86%. Report is 2 commits behind head on main.

:exclamation: Current head 2d5898f differs from pull request most recent head ffc4fea. Consider uploading reports for the commit ffc4fea to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ======================================= Coverage 86.86% 86.86% ======================================= Files 69 69 Lines 4720 4720 ======================================= Hits 4100 4100 Misses 620 620 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GiorgioCerro commented 11 months ago

@mhauru how can we review this? Can you guide us? Are there actual check we can do or maybe not? To me all the changes look reasonable

EdwinB12 commented 11 months ago

I would say the test here is simply if the deployment works. Which it does, so I'm happy to approve based on that and the fact it looks sensible.

mhauru commented 11 months ago

Yeah, I don't know if there's much you can do, other than spot anything that would look suspicious in the code. Running it yourself is a hassle and there are no tests.