Closed mhauru closed 11 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ddb9111
) 86.86% compared to head (2d5898f
) 86.86%. Report is 2 commits behind head on main.:exclamation: Current head 2d5898f differs from pull request most recent head ffc4fea. Consider uploading reports for the commit ffc4fea to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mhauru how can we review this? Can you guide us? Are there actual check we can do or maybe not? To me all the changes look reasonable
I would say the test here is simply if the deployment works. Which it does, so I'm happy to approve based on that and the fact it looks sensible.
Yeah, I don't know if there's much you can do, other than spot anything that would look suspicious in the code. Running it yourself is a hassle and there are no tests.
There are a few things going on here
__main__.py
), since there had been a major version upgrade to pulumi_azure_native since I wrote the script.dtdb
database on that postgres server doesn't work anymore. I opened a Pulumi issue here: https://github.com/pulumi/pulumi-azure-native/issues/2916In some sense this is a regression, since the Pulumi deployment used to just work, and now one part of it fails, and you have create the database manually. However, given that we do some serious upgrading to newer versions for pulumi, postgres, and Azure postgres servers here, I think it might still be worth to merge this.
Closes #148 and #138