alan-turing-institute / DTBase

A starting point from which digital twins can be developed.
MIT License
11 stars 4 forks source link

Overhaul javascript organisation, switch to typescript #179

Closed mhauru closed 7 months ago

mhauru commented 8 months ago

This started as an effort to convert all our javascript to typescript. This required restructuring the code a lot, so in the process I also took care of many other long-standing javascript-related issues:

I appreciate that this is tricky to review since there's so much going on, happy to talk it through. One good bit to read is a new README.md in webapp/base/static, which explains the new organisation of what sort of code should go where.

EDIT: It seems that, very unhelpfully, GitHub does not realise that most of the typescript files are the old javascript files renamed and with small changes, which certainly doesn't make this any easier to review...

mhauru commented 8 months ago

The two failing tests will be fixed by this one: https://github.com/alan-turing-institute/DTBase/pull/180

EdwinB12 commented 8 months ago

@GiorgioCerro - Think you might be more suited to reviewing this PR. I'll try and look over it tomorrow but think it would benefit from your review.

@mhauru - I approved and merged #180 , could you merge it into this PR please so the tests pass?

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (305a1fe) 89.19% compared to head (bc36093) 89.19%.

:exclamation: Current head bc36093 differs from pull request most recent head b031913. Consider uploading reports for the commit b031913 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #179 +/- ## ======================================= Coverage 89.19% 89.19% ======================================= Files 75 75 Lines 5036 5036 ======================================= Hits 4492 4492 Misses 544 544 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GiorgioCerro commented 7 months ago

Great work Markus. I will have a deeper look at that either today or tomorrow!

Things to review (mainly):

Pull locally and check that nothings breaks.

GiorgioCerro commented 7 months ago

Issues: