Create BaseService and incorporate into Ingress and Models

[EdwinB12]

Linked to #184 #181 #81

Tasks:

Compulsory things to do

• [x] Implement BaseService Class and get BaseIngress to Inherit
• [x] Create BaseModel class that inherits from BaseService
• [x] Move Arima over to BaseModel
• [x] Check WeatherIngress still works when inheriting from BaseService Class

Extras

• [ ] Ensure user can override parameters, preferably from GUI
• [ ] Add a run now functionality via frontend
• [ ] Design Scheduler system. This will likely be a PR in its own right as this needs integration with AzureFunctions.

[codecov-commenter]

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (a202d4b) 89.01% compared to head (ba40cca) 89.14%. Report is 2 commits behind head on main.

:exclamation: Current head ba40cca differs from pull request most recent head 944e303. Consider uploading reports for the commit 944e303 to get more accurate results

Files	Patch %	Lines
dtbase/models/arima.py	85.40%	27 Missing :warning:
dtbase/ingress/ingress_weather.py	70.83%	7 Missing :warning:
dtbase/tests/generate_synthetic_data.py	36.36%	7 Missing :warning:
dtbase/services/base.py	92.85%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #190 +/- ## ========================================== + Coverage 89.01% 89.14% +0.12% ========================================== Files 77 76 -1 Lines 5163 5304 +141 ========================================== + Hits 4596 4728 +132 - Misses 567 576 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[EdwinB12]

Remaining jobs on this PR

• [ ] Finish docstring for BaseModel.get_service_data()
• [x] Complete ArimaModel class so get_service_data() returns the list of endpoints/payload pairs.
• [x] Write tests for get_service_data() and call()

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[EdwinB12]

@GiorgioCerro @mhauru

The main things to check in this PR are:

• [ ] Base Class, in particular the call method and login. Could you check how the authentication is done. Think we might want to clean that up. (services/base.py)
• [ ] Implementation of Arima. Each individual function doesn't need as they're just copied over. However, please check the get_service_data() method and how the config is handled. (models/arima.py)
• [ ] tests : Only need to check test_model_arima.py and test_services_base.py
• [ ] Examples and arima folder: I'm proposing removing these files. If you agree we don't need them then they don't need reviewing.
• [ ] Nothing to do with WeatherIngress needs reviewing. The changes in those files are largely refactoring.
• [ ] Please give the ReadMe a quick look over

Thanks!

[EdwinB12]

Thanks for the review @mhauru , I've addressed your comments.

Now, the tests are failing. I wonder if its not worth testing for exact Arima results in the tests? The tests didn't before this and its just causing tests to fall over on 3rd decimal places. .

[mhauru]

Thanks Edwin, I'll try to take a look later today.

Now, the tests are failing. I wonder if its not worth testing for exact Arima results in the tests? The tests didn't before this and its just causing tests to fall over on 3rd decimal places.

Yeah, if it's turning into a pain then we can give this up. Maybe we can do some other sanity checks of the results instead (or do other tests do that already?). You could also reaaally reduce the precision on the checks, but I don't know if we have a guarantee that that won't ever fail, and indeterministically failing tests are nasty.

[mhauru]

I tried running the Azure function locally, had to make this change: #213 but with that it all works nicely.

[EdwinB12]

Changes made, just need an approval @mhauru

[EdwinB12]

closes #184