Closed mhauru closed 6 months ago
The tests fail because of some datetime parsing issue, I'm pretty sure they pass on python 3.11 (they do locally). I'll fix it tomorrow.
Interesting, I had this yesterday. Test fails on one of them and then cancels it on python runs. Rerunning the tests through the github gui seems to work
Attention: Patch coverage is 97.05628%
with 34 lines
in your changes are missing coverage. Please review.
Project coverage is 89.65%. Comparing base (
38cbdc6
) to head (ba20199
).:exclamation: Current head ba20199 differs from pull request most recent head c1cc874. Consider uploading reports for the commit c1cc874 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the speedy review Edwin. I'll merge once tests pass. @GiorgioCerro, feel free to still leave comments if you want to, we can always make post-merge changes.
Changes in this PR:
Benefits of this switch:
localhost:5000/docs
to see the documentation. This was the main reason why I initiated the switch.Downsides of this switch:
dtbase/backend/auth.py
.dtbase/backend/db.py
.Things not done in this PR, but that we may want to do in the future. None of these are urgent though, so not going to get to them immediately:
pydantic.Field
objects. The inputs are already quite comprehensively documented.Closes #167