search

alan-turing-institute / DTBase

A starting point from which digital twins can be developed.
MIT License
11 stars 4 forks source link

Continous deployment #211

Closed GiorgioCerro closed 6 months ago

GiorgioCerro commented 6 months ago

This PR adds an instruction to set the continuous deployment of WebApps (e.g. whenever a new version of a docker container is created, the webapp automatically pulls it). The instruction is very simple, which simply requires to copy a link from the Azure Portal and paste it to the respective docker container (same as creating a Github secret). I checked if this could have been implemented directly with Pulumi, but all the resources I found are not clear enough and it looks like that there's need of at least one manual action, which makes this not worth it, in my opinion. I am happy to spend more time to find another solution if you guys prefer.

Closes #201 .

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (28b1131) 89.01% compared to head (422e936) 89.01%.

:exclamation: Current head 422e936 differs from pull request most recent head 8a7c3fb. Consider uploading reports for the commit 8a7c3fb to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #211 +/- ## ======================================= Coverage 89.01% 89.01% ======================================= Files 77 77 Lines 5163 5163 ======================================= Hits 4596 4596 Misses 567 567 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EdwinB12 commented 6 months ago

Niice. This looks very sensible. I don't think we can really test it anymore than you've already done. The instructions are followable and make sense.

mhauru commented 6 months ago

Thanks Giorgio!