alan-turing-institute / DTBase

A starting point from which digital twins can be developed.
MIT License
11 stars 4 forks source link

Basic backend and frontend service infrastructure #214

Closed mhauru closed 6 months ago

mhauru commented 6 months ago

Adds

No scheduling yet.

Builds on #207, so getting that merged first will make the diff manageable.

mhauru commented 6 months ago

I tagged y'all as reviewers, but maybe hold off until #207 is merged, because right now the diff is entirely unworkable.

mhauru commented 6 months ago

With the FastAPI PR merged, I reset the base branch, so the diff should now make sense.

EdwinB12 commented 6 months ago
image

@mhauru - Could you quickly talk through what you expect from the user? Service Name is explanatory, but URL? Does this mean the service needs to call an API?

mhauru commented 6 months ago

Yes, the URL is the URL to which a REST request should be sent when the service is to be run. E.g. the URL for triggering an Azure function to run.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 86.90141% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 89.31%. Comparing base (ae28d48) to head (952e25a).

:exclamation: Current head 952e25a differs from pull request most recent head 8c17f43. Consider uploading reports for the commit 8c17f43 to get more accurate results

Files Patch % Lines
dtbase/webapp/app/services/routes.py 47.91% 75 Missing :warning:
dtbase/backend/api/service/routes.py 87.50% 14 Missing :warning:
dtbase/core/service.py 96.77% 3 Missing :warning:
dtbase/tests/test_api_services.py 99.37% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #214 +/- ## ========================================== - Coverage 89.65% 89.31% -0.35% ========================================== Files 72 79 +7 Lines 5116 5820 +704 ========================================== + Hits 4587 5198 +611 - Misses 529 622 +93 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.