alan-turing-institute / DTBase

A starting point from which digital twins can be developed.
MIT License
10 stars 4 forks source link

Pulumi fixes #231

Closed mhauru closed 4 months ago

mhauru commented 4 months ago
codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.65%. Comparing base (cfe1c67) to head (1663da9). Report is 4 commits behind head on main.

:exclamation: Current head 1663da9 differs from pull request most recent head 4fa9651. Consider uploading reports for the commit 4fa9651 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #231 +/- ## ======================================= Coverage 90.65% 90.65% ======================================= Files 79 79 Lines 5702 5702 ======================================= Hits 5169 5169 Misses 533 533 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mhauru commented 4 months ago

One change is moving hard coded constants to a config, so it was fine before, but just not as nice. The other one, well, it kinda didn't work. You had to go manually mess with the collation property of the database after Pulumi made it. Pulumi is a bit buggy around creating databases...