search

alan-turing-institute / DTBase

A starting point from which digital twins can be developed.
MIT License
10 stars 4 forks source link

Units fix #254

Closed mhauru closed 3 months ago

mhauru commented 3 months ago

We should always identify measure, both sensor measures and models measures, by a combination of name and units. This PR makes it so. Before this we were doing this correctly in some places, but in other places we relied on the name only.

Closes #245

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.34884% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.06%. Comparing base (298e014) to head (69c5045). Report is 2 commits behind head on main.

:exclamation: Current head 69c5045 differs from pull request most recent head a17d14b. Consider uploading reports for the commit a17d14b to get more accurate results

Files Patch % Lines
dtbase/backend/database/models.py 89.28% 3 Missing :warning:
dtbase/backend/database/sensors.py 88.88% 1 Missing :warning:
dtbase/frontend/app/models/routes.py 92.30% 1 Missing :warning:
dtbase/frontend/app/sensors/routes.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #254 +/- ## ========================================== + Coverage 90.83% 91.06% +0.22% ========================================== Files 78 78 Lines 5674 5695 +21 ========================================== + Hits 5154 5186 +32 + Misses 520 509 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.