search

alan-turing-institute / DetectorChecker

Project to develop software to assess developing detector screen damage (Web App based on the original DetectorChecker package)
https://detectorchecker.azurewebsites.net
MIT License
0 stars 1 forks source link

slot names #43

Closed ejulia17 closed 5 years ago

ejulia17 commented 5 years ago

Dear Oscar,

Many slot names originally had "." in it which where replaced by "_" for the package. This is now different from the technical drawing is in the ReadMe folder of the original code: https://github.com/alan-turing-institute/DetectorChecker/blob/master/Original_code/Readme/layoutParameterDrawing.pdf

I (Julia) will have to change most of the labelling in the technical drawing accordingly in the original keynote file used to make the drawing.

Oscar can you please add missing descriptions in place of "!" in the file layout.R, that is instead of

' @param module_edges_col !

' @param module_edges_row !

make it

' @param module_edges_col vector of columns that contain edges of modules

' @param module_edges_row vector of rows that contain edges of modules

Thanks, Julia

OscartGiles commented 5 years ago

I have updated and this now part of this pull request https://github.com/alan-turing-institute/DetectorChecker/pull/47. There are a few other changes to make relating to issue #41 , and then these will be merged into the development branch.

I will leave this issue open until @ejulia17 has had a chance to work on the technical drawings.